-
Notifications
You must be signed in to change notification settings - Fork 105
Use Hammer CLI in favor of WebUI to change setting #4249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use Hammer CLI in favor of WebUI to change setting #4249
Conversation
All steps but one relies on using CLI, so we should not force the user to complete this single step via WebUI. Tested on Foreman 3.14/Katello 4.16.
The PR preview for e511c08 is available at theforeman-foreman-documentation-preview-pr-4249.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised by this setting even existing and especially where it's defined. It's in Katello:
If we tell users to set this to true, is there a good reason why it's default to false?
@adamruzicka you added the setting in Katello/katello@840cbe6. Can you shine a light on that?
Remote execution has a mechanism for picking a proxy to be used. The mechanism takes many things into consideration and is generally not compatible with katello's "host is registered to a proxy so everything has to be done through that proxy, regardless on subnets and things like that" world view. Hence katello comes with a setting to bend the behaviour of Rex to match katello's customs. I don't like it either, but probably for a different reason.
Mostly to have vanilla foreman and foreman with katello behave the same way with an option to selectively enable different behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense. thanks.
What changes are you introducing?
Replace step that uses Web UI with Hammer CLI command.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
All steps but one relies on using CLI, so we should not force the user to complete this single step via WebUI.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Tested on Foreman 3.14/Katello 4.16.
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):