Reword template based provisioning #4295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
|
The PR preview for fa906af is available at theforeman-foreman-documentation-preview-pr-4295.surge.sh The following output files are affected by this PR: |
Lennonka
requested changes
Oct 2, 2025
|
|
||
| Proxmox uses templates as images for creating virtual machines. | ||
| When you use image-based provisioning to create new hosts, add Proxmox template details to your {Project}. | ||
| Add Proxmox images to {Project} to perform image-based host provisioning on Proxmox. |
There was a problem hiding this comment.
I struggled to remember why this wording was so strange (in VMware).
The problem is this: what we call "images" in Foreman are called "templates" in VMware. I don't know what they call them in Proxmox. I started calling them "image templates" in provisioning methods.
Now I hesitate to change it because it would be good for users' understanding to create a connection between those two terminologies. Could you try to consider an alternative wording?
This applies to all modules in this PR.
pr-processor
bot
added
Waiting on contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Fixes #4288
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Tested Hammer CLI commands for VMware and Proxmox on Foreman 3.14 ✔️
Contributor checklists
Please cherry-pick my commits into: