-
Notifications
You must be signed in to change notification settings - Fork 104
Move troubleshooting sync errors #4298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move troubleshooting sync errors #4298
Conversation
The PR preview for ce68ae8 is available at theforeman-foreman-documentation-preview-pr-4298.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
Could we add an xref to the appendix into the Synchronizing repositories module's .Additional resources
perhaps?
Since it's an appendix, it might be easy to miss by users.
891348f
to
55c36fd
Compare
Yes we can! -> Rebased to HEAD of "master" and added a link. Please re-review. |
* Add link to appropriate modules which could cause the need to troubleshoot * Fix chown command based on man page: you split user and group by colon * Rename file/anchor/title * Use attributes in favor of Katello server Fixes theforeman#1191
55c36fd
to
ce68ae8
Compare
Module is Katello-only -> Link is now also Katello-only. I only ran local tests for Katello builds 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although the fact that the appendix isn't included for satellite and orcharhino builds is surprising to me :)
* Add link to appropriate modules which could cause the need to troubleshoot * Fix chown command based on man page: you split user and group by colon * Rename file/anchor/title * Use attributes in favor of Katello server Fixes #1191
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Fixes #1191
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I ran those commands on Foreman 3.14/Katello 4.16, but without seeing any issues before/after. Aka. I did not have a broken test instance which got repaired by these commands. IMO good enough because the PR only moves the module, but does not make any significant changes.
Contributor checklists
Please cherry-pick my commits into: