-
Notifications
You must be signed in to change notification settings - Fork 105
Add [role="_abstract"] to Managing Security Compliance #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aneta-petrova
merged 5 commits into
theforeman:master
from
aneta-petrova:security_abstract
Oct 3, 2025
Merged
Add [role="_abstract"] to Managing Security Compliance #4299
aneta-petrova
merged 5 commits into
theforeman:master
from
aneta-petrova:security_abstract
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR preview for 70e8137 is available at theforeman-foreman-documentation-preview-pr-4299.surge.sh The following output files are affected by this PR: |
6753181
to
3b51194
Compare
Lennonka
approved these changes
Oct 2, 2025
12661d1
to
70e8137
Compare
Thank you @Lennonka! Per the PR's description, I'm dropping the commit that adds the style before merging. |
aneta-petrova
added a commit
that referenced
this pull request
Oct 3, 2025
* Add [role=_abstract] * Group SCAP cons and refs in an assembly This will help with adjusting the abstracts. * Regroup modules in Configuring compliance methods assembly * Identify and move abstract-type info to abstract (cherry picked from commit 12cd0e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To resolve the ShortDescription issues reported by https://github.com/jhradilek/asciidoctor-dita-vale
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Further changes to abstract are to be expected in the future because the requirements for them are evolving and asciidoctor-dita-vale will include more rules. For now, this PR at least moves us one step closer to being migration-ready.
One additional commit adds a style definition for [role="_abstract"] for easier review. This should be removed before merging.
Contributor checklists
Please cherry-pick my commits into: