-
Notifications
You must be signed in to change notification settings - Fork 104
Distinguish between HTTP booting stages #4304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jloeser
wants to merge
1
commit into
theforeman:master
Choose a base branch
from
ATIX-AG:fix/http-booting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliankolb
requested changes
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions on style/conventions.
guides/common/modules/con_uefi-http-booting-requirements-with-managed-dhcp.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-smart-proxy-for-http-booting.adoc
Outdated
Show resolved
Hide resolved
32f53e6
to
e6b0e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor suggestion. Overall, LGTM style-wise.
During network based provisioning, there are two stages where either TFTP or HTTP(S) can be used: fetching the boot loader and fetching installation files such as Linux kernel and initrd. Both were partly mixed, partly incomplete, and instructions were ambiguous or did not work.
e6b0e6e
to
c7eeabe
Compare
@stejskalleos Can you please review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs style review
Requires a review from docs style/grammar perspective
Needs tech review
Requires a review from the technical perspective
Needs testing
Requires functional testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During network based provisioning, there are two stages where either TFTP or HTTP(S) can be used: fetching the boot loader and fetching installation files such as Linux kernel and initrd.
Both were partly mixed, partly incomplete, and instructions were ambiguous or did not work.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: