Skip to content

Fix power management sections per persona #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

Fix power management sections per persona #4308

merged 2 commits into from
Sep 30, 2025

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Sep 26, 2025 •
edited
Loading

What changes are you introducing?

Moving installer stuff about power management (BMC) from Managing hosts to Installing X

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

To align the procedures with personas: admin vs. non-admin users

SAT-30833 (public)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • Adding usage of power operations as such is out of scope.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

The PR preview for e2e0f8f is available at theforeman-foreman-documentation-preview-pr-4308.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

maximiliankolb
maximiliankolb approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made on suggestion about the WebUI navigation & two about links. Overall LGTM style-wise.

evgeni
evgeni approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tech ack, as there are no technical changes in here (I still think we should drop the "default provider" part, but that's not what this PR is about)

@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Sep 29, 2025
@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Sep 29, 2025
@Lennonka
Copy link
Contributor Author

Unless I get further feedback, I will merge it in the next 24 hours.

@Lennonka Lennonka merged commit c0b3e8f into theforeman:master Sep 30, 2025
9 of 10 checks passed
Lennonka added a commit that referenced this pull request Sep 30, 2025
@Lennonka
Fix power management sections per persona (#4308)
6be0d40
@Lennonka
Copy link
Contributor Author

Cherry picked:

@Lennonka Lennonka deleted the improve-power-management branch September 30, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@evgeni evgeni evgeni approved these changes

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lennonka @evgeni @ekohl @maximiliankolb