Skip to content

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

Reword "following command"; see issue/other PRs.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Fixes #3672

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

This patch is the third part.

Extends PR #4283
Extends PR #4292

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 26, 2025
Copy link

github-actions bot commented Sep 26, 2025

The PR preview for 3296285 is available at theforeman-foreman-documentation-preview-pr-4310.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

$ fd -e adoc . guides/common/modules | sort -u | grep -v "guides/common/modules/con_managing-ostree-content.adoc" | rg -v "guides/common/modules/proc_changing-the-method-the-bootstrap-script-uses-to-download-the-consumer-rpm.adoc" | rg -v "guides/common/modules/proc_registering-hosts-by-using-the-bootstrap-script.adoc" | rg -v "guides/common/modules/proc_creating-custom-rhel-images.adoc" | rg -v "guides/common/modules/proc_enabling-remote-execution-on-the-host.adoc" | rg -v "guides/common/modules/proc_registering-clients-using-the-bootstrap-script.adoc" | rg -v "guides/common/modules/proc_enabling-power-management-on-hosts.adoc" | rg -v "guides/common/modules/proc_providing-an-alternative-fqdn-for-the-host.adoc" | rg -v "guides/common/modules/con_managing-ostree-content.adoc" | xargs rg "following command"

This patch is the third part.

Extends PR theforeman#4283
Extends PR theforeman#4292

Fixes theforeman#3672
@maximiliankolb maximiliankolb force-pushed the fix_3672_following_command_part_3 branch from 2ea7d6f to 3296285 Compare September 26, 2025 13:45
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 29, 2025
@Lennonka Lennonka merged commit 26be3be into theforeman:master Sep 30, 2025
10 checks passed
Lennonka pushed a commit that referenced this pull request Sep 30, 2025
$ fd -e adoc . guides/common/modules | sort -u | grep -v "guides/common/modules/con_managing-ostree-content.adoc" | rg -v "guides/common/modules/proc_changing-the-method-the-bootstrap-script-uses-to-download-the-consumer-rpm.adoc" | rg -v "guides/common/modules/proc_registering-hosts-by-using-the-bootstrap-script.adoc" | rg -v "guides/common/modules/proc_creating-custom-rhel-images.adoc" | rg -v "guides/common/modules/proc_enabling-remote-execution-on-the-host.adoc" | rg -v "guides/common/modules/proc_registering-clients-using-the-bootstrap-script.adoc" | rg -v "guides/common/modules/proc_enabling-power-management-on-hosts.adoc" | rg -v "guides/common/modules/proc_providing-an-alternative-fqdn-for-the-host.adoc" | rg -v "guides/common/modules/con_managing-ostree-content.adoc" | xargs rg "following command"

This patch is the third part.

Extends PR #4283
Extends PR #4292

Fixes #3672
@Lennonka
Copy link
Contributor

Cherry picked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reword "following command"
2 participants