Message verbosity #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is now a `pgenv_message` functions that accepts a message and a level (as a text string) and displays the message (on stderr) only if the current level is the sameor greater of the specified level. Message levels are kept in a globa array `msg_levels` used as an associative array where the message level (e.g., 'info') is the key, and the value is a numeric value. Each time a message is passed to `pgenv_message` the string value is converted to a numeric value and if this is greater or equal to the setting PGENV_VERBOSITY the message will be printed. Advantages: it makes all the messages formatted in the same manner, and it prints all the messages to stderr (good for redirection). All calls to removed function `pgenv_debug` has been modified as `pgenv_message ... 'debug'`. Also converted the initial call to show PGENV_ROOT to a call of level 'warn'. See issue theory#21 Replaced all the "interactive" occurencies of 'echo ' to 'pgenv_message'.
theory
reviewed
Oct 21, 2018
bin/pgenv
Outdated
| msg_levels[info]=10 | ||
| msg_levels[warn]=20 | ||
| msg_levels[error]=25 | ||
| msg_levels[always]=999 |
There was a problem hiding this comment.
These levels are decreasingly verbose as the numbers go up, until always, which is the most verbose. Shouldn't it be 1 (or 0)? Or should the levels be reversed other than always?
Removed level 'always', default to 'info'. See discussion <theory#22 (review)>
|
Doesn't work on macOS Mojave, sadly: > pgenv versions
/Users/david/pg/bin/pgenv: line 8: declare: -A: invalid option
declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
> bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin18)
Copyright (C) 2007 Free Software Foundation, Inc.Maybe use an array and declare variables that hold the log levels? |
Improves portability, since to use an associative array in Bash there is the need to use 'declare -A'. See discussion <theory#22 (review)>.
|
@theory I've replaced the array with an ugly |
|
ISTM most of the messages are set at "info" level, even though a number of them really seem to be warnings or errors. Is there interest in cleaning that up? |
Now all errors and warning use the appropriate level. Removed wrong 'debug' levels that caused all message to be printed as 'info'. See suggestion in <theory#22 (comment)>
|
@xzilla good point! I've placed correct (or I think they are correct) levels in almost every message that deserved. Can you please help improving it (even just reviewing)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to discussion about issue #21 and the need for displaying messages at different level of verbosity.
The idea is to replace
pgenv_debugwith a more generalpgenv_messagethat accepts the verbosity level as an argument (sopgenv_message 'debug'is the same as the oldpgenv_debug). The message is printed only if the required level is lesser than thePGENV_VERBOSITYconfiguration, which defaults to print every message if not specified in the configuration (the above replaces the variablePGENV_DEBUG).Levels are kept in an associative array.