Make the tutorial working again! #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tutorial does not work with the old helm chart. I am testing the new one and it looks like working completely fine.
grhawk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
This tutorial is really well done and explained. Thank you for putting such an effort to the service of the community!
Unfortunately, while trying it, I found out some of the things are out-of-date. In particular, the helm chart used to install the prometheus-operator and the lack of "securityContext" in the Prometheus definition. (The latter does not let the container access the PVC).
With this PR, I am trying to solve all this ood issues.
NB: I did not test Thanos with the long storage because I don't have any S3 service available at this time.