Trying to fix some flakes #4223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
force-pushed
the
some-fixes
branch
2 times, most recently
from
771f16d to
1618f0e
Compare
tmjd
force-pushed
the
some-fixes
branch
4 times, most recently
from
cb58e7f to
3afa009
Compare
| } | ||
| return fmt.Errorf("Only %d available replicas", ds.Status.NumberAvailable) | ||
| }, 240*time.Second).Should(BeNil()) | ||
| By(fmt.Sprintf("calico-node daemonset %v", ds.Status)) |
There was a problem hiding this comment.
I don't think this belongs as a test step
Suggested change
| By(fmt.Sprintf("calico-node daemonset %v", ds.Status)) |
But could be a log line if you want to keep it for debugging?
caseydavenport
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
One small comment, and would be nice to find a way to use the common helper function for this if possible. But otherwise this LGTM. Thanks @tmjd !
Fix test to wait for all calico-node to be available Wait for generation update Bump calico tigerastatus timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've still been getting flakes in the FV tests that have seemed to be related to teardown or not waiting long enough at teardown. These changes attempt to adjust mostly the test code but also the core controller to properly wait for cleanup or updates.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.