[REF] Update ICC profiles and licenses; remove Adobe resources #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sandeepa-12
commented
Sep 27, 2025
sandeepa-12
commented
- Updated LICENSE to reflect new ICC profile sources from colormanagement.org and color.org.
- Replaced Adobe CMYK profile with colormanagement.org profile in CMYK.php.
- Removed obsolete Adobe ICC profiles and related documentation from resources.
- Updated tests to use new profile paths.
- Updated LICENSE to reflect new ICC profile sources from colormanagement.org and color.org. - Replaced Adobe CMYK profile with colormanagement.org profile in CMYK.php. - Removed obsolete Adobe ICC profiles and related documentation from resources. - Updated tests to use new profile paths.
sandeepa-12
commented
Sep 30, 2025
| { | ||
| if (!$this->profile) { | ||
| $this->profile = Profile::fromPath(__DIR__ . '/../../resources/colormanagement.org/ISOcoated_v2_grey1c_bas.ICC'); | ||
| $this->profile = Profile::fromPath(__DIR__ . '/../../resources/color.org/sRGB_IEC61966-2-1_black_scaled.icc'); |
There was a problem hiding this comment.
- ISOcoated_v2_grey1c_bas.ICC is a CMYK color space profile
- It's designed for 4-color printing (Cyan, Magenta, Yellow, Black)
- Grayscale is NOT a CMYK color space - it's a single-channel color mode
- sRGB profile is designed for RGB color space (3 channels: Red, Green, Blue)
- Grayscale is properly handled as a subset of RGB (R=G=B)
- This is the industry-standard approach for grayscale color management
- When R=G=B in RGB, you get grayscale (e.g., RGB(128,128,128) = gray)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.