-
Notifications
You must be signed in to change notification settings - Fork 246
grpc: 1.63.2 -> 1.69.4 #1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
grpc: 1.63.2 -> 1.69.4 #1526
Conversation
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
[LGTM Timeline notifier]Timeline:
|
|
does this PR need work or can it be merged? |
|
@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmeadowcroft, disksing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Any change we could get these in? Just a note that it's not that it's enabled by default, it was completely removed on later versions, which makes it impossible to build as part of any system that is up to date with the grpc libraries. |
grpc.NewSharedBufferPoolis enabled by default in grpc1.69.0, we could remove theGrpcSharedBufferPooloption of client-go.Fore more information, see: https://pkg.go.dev/google.golang.org/grpc/experimental#WithBufferPool