Skip to content

use AsRef<str> for slice of string labels #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use AsRef<str> for slice of string labels #529

wants to merge 1 commit into from

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Nov 8, 2024 •
edited
Loading

So that it would be easier to use when the labels are not static strings.

@tabokie
Copy link
Member Author

tabokie commented Nov 8, 2024

cc @overvenus @Connor1996

Connor1996
Connor1996 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MrCroxx
MrCroxx approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svanharmelen svanharmelen mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@MrCroxx MrCroxx MrCroxx approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabokie @Connor1996 @MrCroxx