Add a feature for push with reqwest rustls #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @silverfoxy! It looks like this is your first PR to tikv/rust-prometheus 🎉 |
Signed-off-by: Bob AminAzad <[email protected]>
|
Hi @lucab, when you have a chance, could you help move this to completion? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this crate with "push" feature in an environment that requires boringssl instead of openssl. So my options for tls library are rustls or boring. With the current configuration, adding push feature pulls in reqwest with default features which relies on native-tls and openssl.
This PR is introducing a new feature (push-rustls) that allows push to work with rustls. I explicitly added the default features from reqwest that would be disabled by this change but do not affect the tls compatibility: https://github.com/seanmonstar/reqwest/blob/master/Cargo.toml#L37C27-L37C61