fix(pulling_gauge): reduce indirection #554
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we stored an
Arc<Box<dyn Fn()>>
, but we can directly store the function in theArc
.We could also take an
impl Fn() -> f64 + Send + Sync
instead of aBox<dyn Fn() -> f64 + Send + Sync>
and do the allocation insidenew
:This is more efficient and lets you write the closure directly on the calling site:
This wouldn't be a breaking change since
Box<dyn Fn()>
implementsFn()
, but it would make it less efficient since you are now storing aBox
inside theArc
.