feat: Add keyboard navigation to role selection popup #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements Arrow Up/Down navigation through filtered role list - Adds Enter key selection for highlighted role - Adds Escape key to clear filter and close popup - Maintains visual selection highlighting with smooth scrolling - Preserves existing mouse click functionality - Includes comprehensive test coverage for edge cases - Updates documentation with keyboard shortcuts usage Addresses GitHub issue tilfinltd#279 Features: - Arrow Down/Up: Navigate through visible (filtered) roles - Enter: Select and switch to highlighted role - Escape: Clear filter and close popup - Auto-selects first matching role when typing filter - Smooth scrolling for roles outside viewport - Proper bounds checking and edge case handling Technical details: - Enhanced setupRoleFilter() function in popup.js - Separated keydown (navigation) from keyup (filtering) events - Added helper functions for visible role management - Uses existing .selected CSS class for highlighting - Works across Chrome, Firefox, and Edge browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses GitHub issue #279
Features:
Technical details: