Skip to content

show message when revising #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

show message when revising #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/packagedef.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,7 @@ If `throw` is `true`, throw any errors that occur during revision or callback;
otherwise these are only logged.
"""
function revise(; throw=false)
printstyled("Revising…", color=:light_black)
sleep(0.01) # in case the file system isn't quite done writing out the new files
lock(revise_lock) do
have_queue_errors = !isempty(queue_errors)
Expand Down Expand Up @@ -881,6 +882,7 @@ function revise(; throw=false)
else
empty!(revision_queue)
end
isempty(revision_errors) || println() # newline after the Revising… message, which will remain because we're showing errors
errors(revision_errors)
if !isempty(queue_errors)
if !have_queue_errors # only print on the first time errors occur
Expand All @@ -902,6 +904,7 @@ function revise(; throw=false)
tracking_Main_includes[] && queue_includes(Main)

process_user_callbacks!(throw=throw)
isempty(revision_errors) && print("\r\e[2K") # clear the Revising… message
end

nothing
Expand Down
Loading