Update list of stdlibs #929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this list need to be version specific? Given some packages have become stdlibs and some stdlibs removed |
|
Could Revise ask Julia about this list? Julia should know its dependencies. |
|
There's |
|
(If it's going to be difficult to figure out how to resolve this in general then I can open another PR that just adds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise's list of stdlibs is incomplete. This is currently a blocker for JuliaLang/julia#58731: This PR updates
LibGit2_jllto a new version, and this version has bothPCRE2_jllandZlib_jllas dependencies. Revise does not know about these two stdlibs, and this makes Julia's CI self tests fail.I don't know whether to add just these two stdlibs, or whether to generally update Revise's list of stdlibs to include all stdlibs. This PR does the latter. Please advise.
After this PR is merged we will need to update the version of Revise used by Julia's CI tests.