Fix null analysis warnings in test files #246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add static keyword to 38 test methods that don't use instance state - Remove unused variable assignment in ModifiableByteTest - Add 'this.' qualifier to field accesses in ModifiableIntegerTest These changes address all null analysis warnings reported in issue #28: - Methods that can be declared static - Unused local variable - Unqualified field access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
statickeyword to test methods that don't use instance statethis.qualifier to field accesses in ModifiableIntegerTest (7 occurrences)Changes Made
Static Method Warnings (38 methods)
Added
statickeyword to test methods across 24 test files:Unused Variable Warning
nullByteHashin ModifiableByteTest.java:201Unqualified Field Access Warnings
this.prefix to all 7 occurrences ofnullIntegerfield access in ModifiableIntegerTest.javaTest plan