Fix equals() symmetry issue in ModifiableLengthField #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ModifiableLengthField.equals()
to handle comparison with different types correctly:ModifiableLengthField
: checks both value and reference equalityModifiableInteger
subclasses: only checks value equality for symmetryModifiableLengthFieldSymmetryTest
with tests for:Test plan
This fix ensures that if
a.equals(b)
returns true, thenb.equals(a)
also returns true, which is required by the equals() contract in Java.