Fix SpotBugs warnings in RandomHelper #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SpotBugs annotations dependency - Suppressed MS_EXPOSE_REP warning on getRandom() method - Suppressed EI_EXPOSE_STATIC_REP2 warning on setRandom() method - Added test to document intentional mutable Random exposure - Added detailed justification for the design decision The RandomHelper class is designed for test environments where controlled randomness is required. Exposing the mutable Random instance is intentional to allow testing frameworks full control over randomness.
TrueSkrillor
added a commit
to tls-attacker/Protocol-Toolkit-BOM
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
The RandomHelper class is designed for test environments where controlled randomness is required. The warnings were about exposing mutable static Random instance, which is intentional in this case to allow testing frameworks full control over randomness.
Changes made:
Test plan
mvn testmvn spotless:check