[AI] Fix Alert(null,null) logging in AlertMessage toCompactString() - Fixes #212 #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, AlertMessage.toCompactString() would return "Alert(null,null)" when the level and description fields were not set. This happened because the method only checked the config field for description but not for level. This commit: - Updates toCompactString() to use config as fallback for both level and description - Returns "not configured" instead of "null" when no values are available - Adds comprehensive unit tests to verify the behavior This provides better logging output before the message is prepared by the AlertPreparator, resolving issue #212.
ic0ns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
AlertMessage.toCompactString()to check config field for both level and description when the respective fields are nullTest plan
AlertMessageToCompactStringTestcovering:This fixes the issue where alert messages show as "Alert(null,null)" in log output before being prepared by AlertPreparator.