Skip to content

Post review blog post

Timothy Chen edited this page Jul 19, 2014 · 2 revisions

The Apache Mesos project has many code contributors, and every code patch requires to go through code review with reviewboard and eventually be committed by the committers.

The steps usually to post your local git commits into reviewboard requires one to manually create a patch file, open and login to reviewboard, upload the patch and fill in manually the description of the review him/herself.

To simplify these steps, the Mesos community has developed a post-review script that helps automate all of these steps.

However, just like git-flow provides a workflow model, post-reviews besides automating posting patches to reviewboard also provides a workflow model that contributors can do that simplify updating and creating reviews. (Mention the Mesos team at Twitter has employed this workflow?)

The following describes what this workflow looks like with post-reviews.

Workflow

Imagine a contributor working on a new feature in Mesos, creates a new branch [new-feature] and start working on the feature.

support/post-review.py

Clone this wiki locally