Skip to content

Conversation

@dschmidt
Copy link
Member

See PR for changes in Tomahawk tomahawk-player/tomahawk#336

I had to change a few occurances of Tomahawk.resolver.instance in here, shouldn't be the case IMHO. We should really get rid of those (relying on a single instance here is a bad thing).

Commits after Soundcloud work are not tested by any means, just wanted to get started and see how multiple files feel.

You need tomahawkcc to compile soundcloud, to a standalone resolver containing all necessary parts of former tomahawk.js, rsvp.js and almond.js (and AMD module loader).

https://github.com/dschmidt/tomahawkcc

If you have a working Node.js environment, simply npm install -g dschmidt/tomahawkcc.

If not, here's a standalone build, which should run on 64bit linux:
http://download.tomahawk-player.org/test/tomahawkcc

xhochy and others added 30 commits November 6, 2014 00:26
- Don't report allowing artist type TomahawkUrl.
Add Urllookup to capabilities.
mrmaffen and others added 29 commits September 16, 2015 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.