Skip to content

Conversation

@MrCroxx
Copy link

@MrCroxx MrCroxx commented Oct 14, 2025

Hi, @tomfran . Thank you for providing the excellent theme. 🥰

This PR fix the image rendering for svg image reousces.

This PR does not address the adjustment of the svg image’s width and height, but as a hotfix, it allows the svg to render correctly without causing an error.

Before #79 and #81 are fixed, I recommend to apply the hotfix to avoid necessary svg usage. 🙏

@tomfran
Copy link
Owner

tomfran commented Oct 15, 2025

Hi thank you for the kind words and the change, could you kindly add a screenshot or something to show how the SVG are rendered? Are they following the existing image classes?

@MrCroxx
Copy link
Author

MrCroxx commented Oct 18, 2025

Hi thank you for the kind words and the change, could you kindly add a screenshot or something to show how the SVG are rendered?

Sure.

Here is an example of svg rendering.

image

BTW, I added a customized css to center all images in my blog:

.img-container img {
    display: block;
    margin-left: auto;
    margin-right: auto;
}

Are they following the existing image classes?

For tags such as #light or #dark, they are. But for resizing, I'm afraid they are not.

In my opinion, as a trade-off, we can first allow users to display SVGs, and then fix the resizing feature later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants