Fixed -dump flag output and improved search engine argument parsing. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when passing arguments to the search engine via the "flags" key in a pattern.json file. the argument would be treated as one single, long argument by `exec.Command`. This is fine when passing arguments like `"-rnwE"` (as this is technically a single argument from the perspective of the shell), however if "flags" was instead defined as `"-r -n -w -E"`, it would be passed as one big argument to the search engine, causing errors (e.g. `"invalid option"` in `grep` and `ag`). This patch ensures that multiple arguments defined in a pattern.json file are treated as seperate arguments (e.g. `-r`, `-n`, `-w`, `-E`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-dumpflag output to show the custom engine (if configured), rather than always showinggrep.