chore: update Rust to nightly-2024-01-20
#306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
spookyvision
added a commit
that referenced
this pull request
Aug 22, 2024
this PR changes the toolchain to use `nightly-2024-07-30` and fixes `platforms/x86_64` dependencies so it uses root's `Cargo.toml` patch section for maitake crates. closes #323 obsoletes #306 TODO for reviewers (roughly ordered by assumed importance): - [ ] ensure `target_has_atomic` is the right fix ( a9e59b1 ) - [ ] [warning: transmute used without annotations --> platforms/allwinner-d1/d1-core/src/drivers/smhc.rs:521:58](https://github.com/tosc-rs/mnemos/blob/update-toolchain/platforms/allwinner-d1/d1-core/src/drivers/smhc.rs#L521) - [ ] [interior mutable const lint](https://github.com/tosc-rs/mnemos/blob/80928e4f13d97ac4e21655ff19b82fa0e5fc2e43/source/spitebuf/src/lib.rs#L182) - [ ] `VAddr::of(&DOUBLE_FAULT_STACK)` ( 1aecece ) - can't use clippy's suggested `ptr::addr_of!` with pinned mycelium (probably best to create dedicated issue) - [ ] warning: struct `GrantWriter` is never constructed: [platforms/allwinner-d1/d1-core/src/drivers/uart.rs:27:8](https://github.com/tosc-rs/mnemos/blob/80928e4f13d97ac4e21655ff19b82fa0e5fc2e43/platforms/allwinner-d1/d1-core/src/drivers/uart.rs#L28) - [ ] warning: struct `GrantWriter` is never constructed: [platforms/esp32c3-buddy/src/drivers/usb_serial.rs:16:8](https://github.com/tosc-rs/mnemos/blob/update-toolchain/platforms/esp32c3-buddy/src/drivers/usb_serial.rs#L16) - [ ] warning: struct `GrantWriter` is never constructed: [platforms/esp32c3-buddy/src/drivers/uart.rs:21:8](https://github.com/tosc-rs/mnemos/blob/update-toolchain/platforms/esp32c3-buddy/src/drivers/uart.rs#L21) - [ ] warning: trait `TryFromBits` is never used: [platforms/allwinner-d1/d1-core/src/plic.rs:186:7](https://github.com/tosc-rs/mnemos/blob/update-toolchain/platforms/allwinner-d1/d1-core/src/plic.rs#L186) - [ ] warning: struct `SingleThreadedLinkedListAllocator` is never constructed: [source/alloc/src/heap.rs:288:12](https://github.com/tosc-rs/mnemos/blob/update-toolchain/source/alloc/src/heap.rs#L288) --------- Co-authored-by: Anatol Ulrich <[email protected]> Co-authored-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates our Rust toolchain to
nightly-2024-01-20. To buildon this nightly, I've removed a no-longer-necessary feature flag, and
updated our
myceliumdeps tohawkw/mycelium@1de8ba1, which includes
fixes for a bunch of new warnings added on recent Rust toolchains.