Skip to content

Allow scope to be passed as a string or an array in get_authorization_url #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow scope to be passed as a string or an array in get_authorization_url #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/instagram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,8 +1435,10 @@ var instagram = function(spec, my) {

var auth_url = url.format(url_obj);

if(Array.isArray(options.scope)) {
auth_url += '&scope=' + options.scope.join('+');
if(Array.isArray(options.scope) || typeof options.scope == 'string') {
auth_url += '&scope=' + (
Array.isArray(options.scope) ? options.scope.join('+') : options.scope
)
}

return auth_url;
Expand Down
27 changes: 23 additions & 4 deletions test/scripts/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var auth = (function(spec, my) {
ok: true,
description: 'Get authorization url'
};

var redirect_uri = 'https://www.foo.com/handleauth';
var expected_url = 'https://api.instagram.com/oauth/authorize?' +
'client_id=1234&redirect_uri=https%3A%2F%2Fwww.foo.' +
Expand All @@ -39,10 +39,10 @@ var auth = (function(spec, my) {
}
return cb_(null, res);
},
'with scope': function(cb_) {
'with scope as an array of options': function(cb_) {
var res = {
ok: true,
description: 'Get authorization url with valid scope'
description: 'Get authorization url with valid scope as an array'
};

var redirect_uri = 'https://www.foo.com/handleauth';
Expand All @@ -51,7 +51,26 @@ var auth = (function(spec, my) {
'com%2Fhandleauth&response_type=code' +
'&scope=likes+comments';
var options = { scope: [ 'likes', 'comments' ] };


if(exp_permissions_url !== instagram.get_authorization_url(redirect_uri, options)) {
res.ok = false;
}
return cb_(null, res);
},

'with scope as a string': function(cb_) {
var res = {
ok: true,
description: 'Get authorization url with valid scope as a string'
};

var redirect_uri = 'https://www.foo.com/handleauth';
var exp_permissions_url = 'https://api.instagram.com/oauth/authorize?' +
'client_id=1234&redirect_uri=https%3A%2F%2Fwww.foo.' +
'com%2Fhandleauth&response_type=code' +
'&scope=likes';
var options = { scope: 'likes' };

if(exp_permissions_url !== instagram.get_authorization_url(redirect_uri, options)) {
res.ok = false;
}
Expand Down