Skip to content

fix(motion-activity-event): correct field name and update to union type #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix(motion-activity-event): correct field name and update to union type #1624

wants to merge 3 commits into from

Conversation

david-gettins
Copy link

  • Allows developers using TypeScript the ability to access the activity type using the correct field name.
  • Gives better code completion feedback.

Resolves #1523

@david-gettins david-gettins mentioned this pull request Jan 16, 2023
Open
@david-gettins
Copy link
Author

I have just seen #1524. Seems this may not be the solution. Perhaps PR #1335 should be closed since it is misleading?

@david-gettins
Copy link
Author

Closing as this has been fixed in another PR by @christocracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Typescript interface MotionActivityEvent
1 participant
@david-gettins