Skip to content

Fix local-lib, add local-lib caching #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix local-lib, add local-lib caching #59

wants to merge 3 commits into from

Conversation

mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Oct 29, 2017 •
edited
Loading

  • Add sudo: false to use Docker for more speed
  • Add apt-get aspell so Test::Spelling doesn't fail
  • Stop local-lib-installer producing stdout that breaks local-lib
  • Add documentation for local-lib
  • Add local-lib cache that caches a local::lib called cache

EDIT: the sudo changes has been removed, including the aspell one.

@mohawk2 mohawk2 force-pushed the fix-ci branch 10 times, most recently from 14f65f1 to 016ea35 Compare October 29, 2017 21:53
haarg
haarg requested changes Oct 30, 2017
View reviewed changes
Copy link
Member

@haarg haarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR could benefit from being split up.

bin/local-lib-cache
perlbrew lib create "$full_version"
perlbrew use "$full_version"
rm -rf "$perlbrew_location"
ln -s "$cache_location" "$perlbrew_location"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the cache location could just be used directly rather than using a symlink.

@mohawk2 mohawk2 force-pushed the fix-ci branch 2 times, most recently from 631911b to 3e0195c Compare March 1, 2020 23:34
@mohawk2 mohawk2 changed the title Fix CI and local-lib, add local-lib caching Fix local-lib, add local-lib caching Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haarg haarg haarg requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mohawk2 @haarg