Skip to content

Conversation

rafaelrpinto
Copy link

@rafaelrpinto rafaelrpinto commented May 11, 2019

This PR addresses the following issues:

Look for the stage in the options and provider objects

Currently if no stage is informed as option the deployment fails with:

Serverless Error ---------------------------------------
 
  Missing required key 'Value' in params.Tags[0]

I added a logic to look for the stage on the provider object when it is not available on the options.

Plugin throws an error message when there are no changes to deploy

Currently when there are no changes to deploy the plugin throws (described on #9 ):

Serverless: Packaging service...
Serverless: Service files not changed. Skipping deployment...
Serverless: Creating CloudFormation ChangeSet [...]...

  Serverless Error ---------------------------------------

  S3 error: Unable to get the object https://s3.amazonaws.com/...

I added a logic to check this.shouldNotDeploy variable before doing anything. This way the plugin skips the creation of the changeset when there are no changes.

@rafaelrpinto rafaelrpinto changed the title use provider stage & do not deploy when there are no changes Fix stage set on provider & skip execution when there are no changes May 11, 2019
@rafaelrpinto rafaelrpinto changed the title Fix stage set on provider & skip execution when there are no changes Look for stage on both options and provider & skip execution when there are no changes May 11, 2019
@mt-micky
Copy link

@rafaelrpinto why did you close this PR? It looks like it would fix the two main issues of this plugin

@rafaelrpinto
Copy link
Author

@mt-micky

I don't really remember why :P
Reopening as requested.

Cheers,

@rafaelrpinto rafaelrpinto reopened this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants