fix(Workspace): wrong assumption caused WM to SEGV when a focused window was being unmanaged by the WM and there's not any other window to focus #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow was being unmanaged by the WM and there's not any other window to focus
If `wasFocused` is `true`, the value of `new_focused_window` shouldn't
be NULL, but in a specific scenario, it is, and the window manager just
SEGV. I triggered this SIGSEGV myself while using NEXTSPACE. Debian 12
under Bedrock Linux (no influence of other distros, only Debian packages
& build tools).
The flow of:
```
1534 | if (!wwin->prev && !wwin->next) {
1535 | /* was the only window */
1536 | scr->focused_window = NULL;
1537 | new_focused_window = NULL;
```
doesn't set `wasFocused` to `false`, but `new_focused_window` is NULL,
and this code flow segfaults the entire WM.
Crash:
```
Thread 4 "Workspace" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffeefd56c0 (LWP 70817)]
0x000055555561d3f3 in wUnmanageWindow (wwin=0x7fffe0036fb0, restore=0,
destroyed=1) at WM/window.c:1560
1560 WApplication *napp = wApplicationOf(new_focused_window->main_window);
(gdb) bt
destroyed=1) at WM/window.c:1560
at WM/event.c:647
at WM/event.c:231
at WM/event.c:949
at WM/event.c:239
at WM/core/wevent.c:227
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
wasFocusedistrue, the value ofnew_focused_windowshouldn't be NULL, but in a specific scenario, it is, and the window manager just SEGV. I triggered this SIGSEGV myself while using NEXTSPACE. Debian 12 under Bedrock Linux (no influence of other distros, only Debian packages & build tools).The flow of:
doesn't set
wasFocusedtofalse, butnew_focused_windowis NULL, and this code flow segfaults the entire WM.Crash: