-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Feature: Add trade and secured fields to THORChain Asset #4500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
satoshiotomakan
merged 19 commits into
trustwallet:master
from
enriquesouza:feature/thorchain-asset-trade-secured-fields
Oct 21, 2025
Merged
Feature: Add trade and secured fields to THORChain Asset #4500
satoshiotomakan
merged 19 commits into
trustwallet:master
from
enriquesouza:feature/thorchain-asset-trade-secured-fields
Oct 21, 2025
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouza/wallet-core into wasm_instantiate_contract_fixed
- Add trade and secured boolean fields to Asset proto message - Update ThorchainAsset struct in Rust with new fields - Update asset initialization in tx_builder.rs - Matches Thorchain blockchain Asset struct definition
Parece que você está tentando incluir a descrição de um commit do GitHub em
uma mensagem ou documento relacionado à sua chave Pix.
Aqui está uma sugestão de como você pode formatar essa informação:
*Chave Pix:* ***@***.***
*Commit relacionado:* b3d8c29
*Descrição do commit:*
- Resumo do commit: b3d8c29
- Commit rastreado: 0feea3e
- MsgInstantiateContract: 96be0ef
- ...
- Links do patch: (ligação indisponível) e (ligação indisponível)
Você pode adaptar essa formatação para se adequar às suas necessidades
específicas. Lembre-se de que a descrição do commit parece estar
relacionada a um projeto de desenvolvimento de software e pode não ter uma
conexão direta com a sua chave Pix. Se você precisar de mais ajuda, por
favor, forneça mais contexto!
Em seg., 22 de set. de 2025, 7:26 PM, Enrique Souza <
***@***.***> escreveu:
… ------------------------------
You can view, comment on, or merge this pull request online at:
#4500
Commit Summary
- b3d8c29
<b3d8c29>
my tracked commit
- 0feea3e
<0feea3e>
MsgInstantiateContract
- 96be0ef
<96be0ef>
revert formatting
- 033804a
<033804a>
test
- a3a1c87
<a3a1c87>
Tests fixes and broadcast
- b1cfcf3
<b1cfcf3>
Merge branch 'master' into wasm_instantiate_contract_fixed
- 94e6b0c
<94e6b0c>
Merge branch 'master' into wasm_instantiate_contract_fixed
- 3b9d6d5
<3b9d6d5>
Merge branch 'master' into wasm_instantiate_contract_fixed
- 357ae25
<357ae25>
cargo fmt
- 82722c4
<82722c4>
Merge branch 'master' into wasm_instantiate_contract_fixed
- fef4028
<fef4028>
Merge branch 'wasm_instantiate_contract_fixed' of github.com:enriquesouza/wallet-core
into wasm_instantiate_contract_fixed
- ff1f177
<ff1f177>
remove unused
- 96b837f
<96b837f>
feat: add trade and secured fields to Thorchain Asset
File Changes
(8 files <https://github.com/trustwallet/wallet-core/pull/4500/files>)
- *M* rust/tw_cosmos_sdk/Protobuf/cosmwasm_wasm_v1_tx.proto
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-54f9cd84709a73b6c33a58bca520f5a9aa0a1485842e41030201fabf50992de6>
(9)
- *M* rust/tw_cosmos_sdk/Protobuf/thorchain_bank_tx.proto
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-6473602d2b093d876b7499fe14d2a5ad7e0fb0062098cdff7b1dc146271bca5b>
(6)
- *M* rust/tw_cosmos_sdk/src/modules/tx_builder.rs
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-bf8bfc3aedae8f8f94fd7db40f36f8add9b1442bd300f7a376177c4f89f4ac45>
(49)
- *M* rust/tw_cosmos_sdk/src/transaction/message/mod.rs
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-c88096afaa7e8f4221e7a45a57836fef491b49a2849fad6196c540b0778bb044>
(1)
- *M* rust/tw_cosmos_sdk/src/transaction/message/thorchain_message.rs
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-3d043ec0f2abc88b470de4f55e6351f9fe353a8b688940fdb27bcdfae72c65d7>
(4)
- *A*
rust/tw_cosmos_sdk/src/transaction/message/wasm_message_instantiate_contract.rs
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-2b513ddb88bc8e64d102c588676e7dc24ddd66eb14b81d893e1f544de5d41f0b>
(103)
- *M* rust/tw_cosmos_sdk/tests/sign_wasm_contract.rs
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-9a40e9fe331653b251e2a36e23b814fc555ff190cd908ff92c74c011ea28dd03>
(50)
- *M* src/proto/Cosmos.proto
<https://github.com/trustwallet/wallet-core/pull/4500/files#diff-e4394a6161a22286288e4cf52fdec29c553df3576d3665b8a8c33f0c0c058e37>
(24)
Patch Links:
- https://github.com/trustwallet/wallet-core/pull/4500.patch
- https://github.com/trustwallet/wallet-core/pull/4500.diff
—
Reply to this email directly, view it on GitHub
<#4500>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2PQQHHIHHCARYAWN3O6HET3UBZSDAVCNFSM6AAAAACHGWPJQSVHI2DSMVQWIX3LMV43ASLTON2WKOZTGQ2DEOJWGI4TOOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@satoshiotomakan can you review that? |
satoshiotomakan
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for the delay, we're fully loaded right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 Feature: Add trade and secured fields to THORChain Asset
Overview
This PR adds support for two new boolean fields — trade and secured — to the THORChainAsset and related message structures.
These fields align Wallet Core with the latest THORNode common.proto definitions and are required for handling secured assets and tradeable assets in the THORChain ecosystem.
✅ Changes
• Protobuf updates
• Updated thorchain_bank_tx.proto and Cosmos.proto to include:
bool trade = 5;
bool secured = 6;
📦 Files Modified
• rust/tw_cosmos_sdk/Protobuf/thorchain_bank_tx.proto
• rust/tw_cosmos_sdk/src/modules/tx_builder.rs
• rust/tw_cosmos_sdk/src/transaction/message/thorchain_message.rs
• src/proto/Cosmos.proto
🧪 Testing
• Verified end-to-end using Vultisig iOS PR #3021
→ Successful transaction on THORChain
• Confirmed correct serialization, broadcast, and asset recognition for secured assets.
🔗 Related
• Vultisig iOS PR #3009 — Feature integration for secured THOR assets
• Vultisig iOS PR #3021 — Transaction test and verification
⚙️ Notes
• Fully backward-compatible: existing THORChain assets remain unaffected.
• Enables upcoming functionality for secured asset trades and asset classification within Wallet Core.