Skip to content

Conversation

enriquesouza
Copy link
Contributor

@enriquesouza enriquesouza commented Sep 22, 2025

🧩 Feature: Add trade and secured fields to THORChain Asset

Overview

This PR adds support for two new boolean fields — trade and secured — to the THORChainAsset and related message structures.
These fields align Wallet Core with the latest THORNode common.proto definitions and are required for handling secured assets and tradeable assets in the THORChain ecosystem.

✅ Changes
• Protobuf updates
• Updated thorchain_bank_tx.proto and Cosmos.proto to include:

bool trade = 5;
bool secured = 6;

•	Rust implementation
•	Updated ThorchainAsset struct and corresponding conversions.
•	Adjusted tx_builder.rs to correctly map and serialize new fields.

📦 Files Modified
• rust/tw_cosmos_sdk/Protobuf/thorchain_bank_tx.proto
• rust/tw_cosmos_sdk/src/modules/tx_builder.rs
• rust/tw_cosmos_sdk/src/transaction/message/thorchain_message.rs
• src/proto/Cosmos.proto

🧪 Testing
• Verified end-to-end using Vultisig iOS PR #3021
Successful transaction on THORChain
• Confirmed correct serialization, broadcast, and asset recognition for secured assets.

🔗 Related
Vultisig iOS PR #3009 — Feature integration for secured THOR assets
Vultisig iOS PR #3021 — Transaction test and verification

⚙️ Notes
• Fully backward-compatible: existing THORChain assets remain unaffected.
• Enables upcoming functionality for secured asset trades and asset classification within Wallet Core.

@Ruyeduardo
Copy link

Ruyeduardo commented Sep 23, 2025 via email

@enriquesouza
Copy link
Contributor Author

@satoshiotomakan can you review that?

@enriquesouza enriquesouza changed the title Feature/thorchain asset trade secured fields Feature: Add trade and secured fields to THORChain Asset Oct 13, 2025
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay, we're fully loaded right now

@satoshiotomakan satoshiotomakan merged commit fe280e4 into trustwallet:master Oct 21, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants