-
Notifications
You must be signed in to change notification settings - Fork 79
Prevent iterating over a TopologyCounter #3202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a97abc to
ddb4787
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3202 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 29 29
Lines 30605 30607 +2
Branches 5614 5614
=======================================
+ Hits 27439 27441 +2
Misses 1780 1780
Partials 1386 1386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
I'm not sure. I think @daniel-goldstein suggested actually implementing the iterator in #1462 (comment) rather than making it bomb out. It should be easy, it's just choosing either 1 or 2 from his list. Do you have a preference @benjeffery ? |
|
Is what I've done here correct in that iterating |
|
Let's take the simple path here and raise an error rather than try to implement the right thing |
Yes, my focus was on preventing the easy to trigger infinite loop. |
ddb4787 to
e49d5e7
Compare
|
@jeromekelleher Can I get a tick here? I don't think it is worth doing more than this, we just want to prevent infinite iteration. |
Fixes #1462