Add link-ancestors to TreeSequence and ImmutableTableCollection #3312
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
- Coverage 89.80% 89.73% -0.07%
==========================================
Files 29 29
Lines 31026 31079 +53
Branches 5679 5686 +7
==========================================
+ Hits 27863 27890 +27
- Misses 1777 1802 +25
- Partials 1386 1387 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
I think the motivation for not making this a TS method earlier was that the API seemed not totally mature. But maybe that ship has sailed. |
|
|
||
| def map_ancestors(self, *args, **kwargs): | ||
| """ | ||
| Deprecated alias for :meth:`link_ancestors`. |
There was a problem hiding this comment.
maybe this is our opportunity to remove map_ancestors?
There was a problem hiding this comment.
although that would doubtless break someone's code somewhere...
There was a problem hiding this comment.
Let's not bother - it's not doing any harm and no point in breaking code if we don't have to
|
I meant "looks good except the code coverage" |
| assert ancestor_table == lib_result | ||
| ts_result = ts.link_ancestors(samples, ancestors) | ||
| assert ancestor_table == ts_result | ||
| if _tskit.HAS_NUMPY_2: |
There was a problem hiding this comment.
I don't think the HAS_NUMPY_2 thing is needed, should work either way right?
|
|
||
| def map_ancestors(self, *args, **kwargs): | ||
| """ | ||
| Deprecated alias for :meth:`link_ancestors`. |
There was a problem hiding this comment.
Let's not bother - it's not doing any harm and no point in breaking code if we don't have to
3 participants
Fixes #3311
As this method doesn't mutate tables - shouldn't it be on
TreeSequenceandImmutableTC?