Skip to content

Make ros test topics local to allow for namespacing #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: humble
Choose a base branch
from
Draft

Make ros test topics local to allow for namespacing #28

wants to merge 1 commit into from

Conversation

@hilary-luo
Copy link
Contributor

@hilary-luo hilary-luo commented Nov 2, 2023

Description

Update topics in ros tests to make them local to allow for namespacing

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have tested all of the tests available on the turtlebot4 lite.

# Run this command
ros2 run turtlebot4_tests ros_tests --ros-args -r __ns:=/robot2

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@hilary-luo hilary-luo requested review from roni-kreinin and removed request for roni-kreinin November 2, 2023 20:28
@hilary-luo hilary-luo marked this pull request as draft November 2, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roni-kreinin roni-kreinin Awaiting requested review from roni-kreinin roni-kreinin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hilary-luo