ntfsprogs/mkntfs: improve error when creating NTFS on a plain file #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkntfs is special among all other mkfs utilities in that it'd refuse to create an FS over a plain file (which is often needed for testing purposes). This might seem like an odd choice, but it has to do with how NTFS works, and the error is there to make sure things wouldn't go south for a user. However, it lacked the explanation what exactly may be wrong, not to mention it also didn't mention that FS could be created by passing `--force`. Fix that. Fixes: tuxera#145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkntfs is special among all other mkfs utilities in that it'd refuse to create an FS over a plain file (which is often needed for testing purposes). This might seem like an odd choice, but it has to do with how NTFS works, and the error is there to make sure things wouldn't go south for a user.
However, it lacked the explanation what exactly may be wrong, not to mention it also didn't mention that FS could be created by passing
--force. Fix that.Fixes: #145