Skip to content

Conversation

@julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 2, 2025

This PR bumps sass from 1.90.0 to 1.93.3

While running npm run css, got this warning, but this is the same as for v6-dev branch. It comes from cleancss (in npm run css-minify-* scripts):

See warning message...
WARNING: Invalid character(s) 'color-scheme: light dark;
  --bs-gray-100: #f8f9fa;
  --bs-gray-200: #e9ecef;
  --bs-gray-300: #dee2e6;
  --bs-gray-400: #ced4da;
  --bs-gray-500: #adb5bd;
  --bs-gray-600: #6c757d;
  --bs-gray-700: #495057;
  --bs-gray-800: #343a40;
  --bs-gray-900: #212529;
  --bs-blue-100: #cfe2ff;
  --bs-blue-200: #9ec5fe;
  --bs-blue-300: #6ea8fe;
  --bs-blue-400: #3d8bfd;
  --bs-blue-500: #0d6efd;
  --bs-blue-600: #0a58ca;
  --bs-blue-700: #084298;
  --bs-blue-800: #052c65;
  --bs-blue-900: #031633;
  --bs-indigo-100: #e0cffc;
  --bs-indigo-200: #c29ffa;
  --bs-indigo-300: #a370f7;
  --bs-indigo-400: #8540f5;
  --bs-indigo-500: #6610f2;
  --bs-indigo-600: #520dc2;
  --bs-indigo-700: #3d0a91;
  --bs-indigo-800: #290661;
  --bs-indigo-900: #140330;
  --bs-purple-100: #e2d9f3;
  --bs-purple-200: #c5b3e6;
  --bs-purple-300: #a98eda;
  --bs-purple-400: #8c68cd;
  --bs-purple-500: #6f42c1;
  --bs-purple-600: #59359a;
  --bs-purple-700: #432874;
  --bs-purple-800: #2c1a4d;
  --bs-purple-900: #160d27;
  --bs-pink-100: #f7d6e6;
  --bs-pink-200: #efadce;
  --bs-pink-300: #e685b5;
  --bs-pink-400: #de5c9d;
  --bs-pink-500: #d63384;
  --bs-pink-600: #ab296a;
  --bs-pink-700: #801f4f;
  --bs-pink-800: #561435;
  --bs-pink-900: #2b0a1a;
  --bs-red-100: #f8d7da;
  --bs-red-200: #f1aeb5;
  --bs-red-300: #ea868f;
  --bs-red-400: #e35d6a;
  --bs-red-500: #dc3545;
  --bs-red-600: #b02a37;
  --bs-red-700: #842029;
  --bs-red-800: #58151c;
  --bs-red-900: #2c0b0e;
  --bs-orange-100: #ffe5d0;
  --bs-orange-200: #fecba1;
  --bs-orange-300: #feb272;
  --bs-orange-400: #fd9843;
  --bs-orange-500: #fd7e14;
  --bs-orange-600: #ca6510;
  --bs-orange-700: #984c0c;
  --bs-orange-800: #653208;
  --bs-orange-900: #331904;
  --bs-yellow-100: #fff3cd;
  --bs-yellow-200: #ffe69c;
  --bs-yellow-300: #ffda6a;
  --bs-yellow-400: #ffcd39;
  --bs-yellow-500: #ffc107;
  --bs-yellow-600: #cc9a06;
  --bs-yellow-700: #997404;
  --bs-yellow-800: #664d03;
  --bs-yellow-900: #332701;
  --bs-green-100: #d1e7dd;
  --bs-green-200: #a3cfbb;
  --bs-green-300: #75b798;
  --bs-green-400: #479f76;
  --bs-green-500: #198754;
  --bs-green-600: #146c43;
  --bs-green-700: #0f5132;
  --bs-green-800: #0a3622;
  --bs-green-900: #051b11;
  --bs-teal-100: #d2f4ea;
  --bs-teal-200: #a6e9d5;
  --bs-teal-300: #79dfc1;
  --bs-teal-400: #4dd4ac;
  --bs-teal-500: #20c997;
  --bs-teal-600: #1aa179;
  --bs-teal-700: #13795b;
  --bs-teal-800: #0d503c;
  --bs-teal-900: #06281e;
  --bs-cyan-100: #cff4fc;
  --bs-cyan-200: #9eeaf9;
  --bs-cyan-300: #6edff6;
  --bs-cyan-400: #3dd5f3;
  --bs-cyan-500: #0dcaf0;
  --bs-cyan-600: #0aa2c0;
  --bs-cyan-700: #087990;
  --bs-cyan-800: #055160;
  --bs-cyan-900: #032830;
  --bs-primary: #6f42c1;
  --bs-secondary: #6c757d;
  --bs-success: #198754;
  --bs-info: #0dcaf0;
  --bs-warning: #ffc107;
  --bs-danger: #dc3545;
  --bs-light: #f8f9fa;
  --bs-dark: #212529;
  --bs-primary-base: var(--bs-blue-500);
  --bs-primary-text: light-dark(var(--bs-blue-600), var(--bs-blue-300));
  --bs-primary-bg: light-dark(var(--bs-blue-500), var(--bs-blue-500));
  --bs-primary-bg-subtle: light-dark(var(--bs-blue-100), var(--bs-blue-900));
  --bs-primary-bg-muted: light-dark(var(--bs-blue-200), var(--bs-blue-800));
  --bs-primary-border: light-dark(var(--bs-blue-300), var(--bs-blue-600));
  --bs-primary-focus-ring: color-mix(in oklch, var(--bs-blue-500) 50%, var(--bs-bg));
  --bs-primary-contrast: var(--bs-white);
  --bs-accent-base: var(--bs-indigo-500);
  --bs-accent-text: light-dark(var(--bs-indigo-600), var(--bs-indigo-300));
  --bs-accent-bg: light-dark(var(--bs-indigo-500), var(--bs-indigo-500));
  --bs-accent-bg-subtle: light-dark(var(--bs-indigo-100), var(--bs-indigo-900));
  --bs-accent-bg-muted: light-dark(var(--bs-indigo-200), var(--bs-indigo-800));
  --bs-accent-border: light-dark(var(--bs-indigo-300), var(--bs-indigo-600));
  --bs-accent-focus-ring: color-mix(in oklch, var(--bs-indigo-500) 50%, var(--bs-bg));
  --bs-accent-contrast: var(--bs-white);
  --bs-danger-base: var(--bs-red-500);
  --bs-danger-text: light-dark(var(--bs-red-600), var(--bs-red-300));
  --bs-danger-bg: light-dark(var(--bs-red-500), var(--bs-red-500));
  --bs-danger-bg-subtle: light-dark(var(--bs-red-100), var(--bs-red-900));
  --bs-danger-bg-muted: light-dark(var(--bs-red-200), var(--bs-red-800));
  --bs-danger-border: light-dark(var(--bs-red-300), var(--bs-red-600));
  --bs-danger-focus-ring: color-mix(in oklch, var(--bs-red-500) 50%, var(--bs-bg));
  --bs-danger-contrast: var(--bs-white);
  --bs-warning-base: var(--bs-yellow-500);
  --bs-warning-text: light-dark(var(--bs-yellow-700), var(--bs-yellow-300));
  --bs-warning-bg: light-dark(var(--bs-yellow-500), var(--bs-yellow-500));
  --bs-warning-bg-subtle: light-dark(var(--bs-yellow-100), var(--bs-yellow-900));
  --bs-warning-bg-muted: light-dark(var(--bs-yellow-200), var(--bs-yellow-800));
  --bs-warning-border: light-dark(var(--bs-yellow-300), var(--bs-yellow-600));
  --bs-warning-focus-ring: color-mix(in oklch, var(--bs-yellow-500) 50%, var(--bs-bg));
  --bs-warning-contrast: var(--bs-gray-900);
  --bs-success-base: var(--bs-green-500);
  --bs-success-text: light-dark(var(--bs-green-600), var(--bs-green-300));
  --bs-success-bg: light-dark(var(--bs-green-500), var(--bs-green-500));
  --bs-success-bg-subtle: light-dark(var(--bs-green-100), var(--bs-green-900));
  --bs-success-bg-muted: light-dark(var(--bs-green-200), var(--bs-green-800));
  --bs-success-border: light-dark(var(--bs-green-300), var(--bs-green-600));
  --bs-success-focus-ring: color-mix(in oklch, var(--bs-green-500) 50%, var(--bs-bg));
  --bs-success-contrast: var(--bs-white);
  --bs-info-base: var(--bs-cyan-500);
  --bs-info-text: light-dark(var(--bs-cyan-600), var(--bs-cyan-300));
  --bs-info-bg: light-dark(var(--bs-cyan-500), var(--bs-cyan-500));
  --bs-info-bg-subtle: light-dark(var(--bs-cyan-100), var(--bs-cyan-900));
  --bs-info-bg-muted: light-dark(var(--bs-cyan-200), var(--bs-cyan-800));
  --bs-info-border: light-dark(var(--bs-cyan-300), var(--bs-cyan-600));
  --bs-info-focus-ring: color-mix(in oklch, var(--bs-cyan-500) 50%, var(--bs-bg));
  --bs-info-contrast: var(--bs-gray-900);
  --bs-secondary-base: var(--bs-gray-300);
  --bs-secondary-text: light-dark(var(--bs-gray-600), var(--bs-gray-400));
  --bs-secondary-bg: light-dark(var(--bs-gray-300), var(--bs-gray-600));
  --bs-secondary-bg-subtle: light-dark(var(--bs-gray-100), var(--bs-gray-800));
  --bs-secondary-bg-muted: light-dark(var(--bs-gray-200), var(--bs-gray-700));
  --bs-secondary-border: light-dark(var(--bs-gray-300), var(--bs-gray-600));
  --bs-secondary-focus-ring: color-mix(in oklch, var(--bs-gray-500) 50%, var(--bs-bg));
  --bs-secondary-contrast: light-dark(var(--bs-gray-900), var(--bs-white));
  --bs-black: #000;
  --bs-white: #fff;
' at dist/css/bootstrap.css:9:2. Ignoring.

I also executed npm run dist in this branch and in v6-dev. The comparison of both dist directories shows no diff at all.

Note

@mdo You can check more precisely the release notes if things can be useful on your side in terms of new Sass features

@julien-deramond julien-deramond requested a review from mdo September 2, 2025 21:40
@julien-deramond julien-deramond marked this pull request as ready for review September 2, 2025 21:40
@mdo mdo requested review from a team as code owners September 10, 2025 03:45
@julien-deramond julien-deramond force-pushed the v6-dev-jd-bump-sass-to-1.92.0 branch 2 times, most recently from e4ef391 to d0386b9 Compare September 10, 2025 20:13
@julien-deramond julien-deramond changed the title Build(deps-dev): Bump sass from 1.90.0 to 1.92.0 Build(deps-dev): Bump sass from 1.90.0 to 1.92.1 Sep 10, 2025
@mdo mdo force-pushed the v6-dev branch 2 times, most recently from 90b7cc6 to 21491d1 Compare September 21, 2025 05:15
mdo and others added 18 commits October 10, 2025 10:02
* Don't disallow calc()

* Remove disables that aren't needed

* Remove custom subtract and add functions

* Remove more disables

* keep it here
* Convert .ratio helper to new .ratio utility

* Fix up

* Fix links for now, even though they'll be deleted
* Drop clearfix for display: flow-root

* Fix links
#41687)

* Rename mh-* and mw-* to max-h/w-*, add additional width and height values

Fixes #41330, fixes #40674.

* Bump bundlewatch
* Remove all deprecated Sass variables and deprecation notices from docs components

* Fix linter error

* fix
* Remove added badges from docs pages

* Remove AddedIn
…s and extra dependencies once we migrate to Sass modules (#41697)
* Reorganize scss folder

* Migrate to Sass modules

* Migrate docs to Sass modules, comment out docs grid CSS

* Give helpers folder an index.scss, migrate ratio helper to aspect-ratio utility

* Delete node sass Action

* Modify Sass tests to pass for new Sass modules implementation

* Don't disallow calc()

* Move heading classes back to Reboot to prevent a dependency

* Utilities, some helpers, and theme colors

* Temporary fix of docs compilation

* Temporary Bundlewatch fix

* docs fix import to use

* Restyle docs callouts

* Fix docs colors

* Revert typo

* Reintroduce `css-lint-vars` npm script

* Bump to Sass v1.90.x

* Fixes

* more

* Remove

---------

Co-authored-by: Julien Déramond <[email protected]>
* First pass at CSS layers

* bundlewatch

* more bundlewatch
…41702)

* Restore both grids and update mixins

* Bundlewatch
* Co-locate Sass variables in most files

* another

* fix

* Don't bring tables into reboot, temp remove some sass vars so we don't need the co-dependency

* Move vars

* bundlewatch

* scssdocs

* Fix scssdocs
…me pages (MDN, CSS Tricks) (#41749)

* wip

* improve

* Add more utility refs

* Remove important flag from the utilities

* update

* Start on helpers

* fixes

* fix links
* Remove !important from utilities, make it opt-in per utility

* package-lock

* Fix test
mdo and others added 15 commits October 10, 2025 10:03
* Add utilities for place-items and justify-items

* bump
* Split the flex.mdx file into separate pages

* Add subgroups to docs utils nav

* More new groups, split pages

* Update MDX linter

* fixes
* wip

* More updates
* Use `@forward` instead of `@use` for proper customization

* linty linterson

* woof
* New form controls

* Split Sass, update docs

* More migration docs

* basic migration, update changelog

* Bring back btn-check for now, but move to button stylesheet

* note

* Fix link

* lint
* Start to redo generate-utility()

* fixes

* bundlewatch
* Update xxl breakpoint and container, rename xxl to 2xl for better scaling

Co-Authored-By: mdo <[email protected]>

* note for lg

* bump bundlewatch

---------

Co-authored-by: mdo <[email protected]>
* New validator

* update

* remove

* update
* new colors

* WIP: Redo some theming

* Fix sass warnings on unquoted map keys

* Revamp colors, update docs, couple new utils

* Remove key attributes

* Bump bundlewatch

* Bundlewatch

* Fix some things up

* Clean up tables, more color changes

* Fix more table color generation, simplify markup with new Table component prop

* More docs improvements, including utilities API, and checkbox and radio theme variants
* wip

Co-Authored-By: mdo <[email protected]>

* linty linterton

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: mdo <[email protected]>
* Move some docs content around

* Update links
mdo and others added 2 commits October 13, 2025 21:39
* New theme classes, revamped buttons

* bundle, lint, more cleanup

* update checks and radios

* Improve table theme variant usage

* remove table-border-factor
@julien-deramond julien-deramond force-pushed the v6-dev-jd-bump-sass-to-1.92.0 branch from d0386b9 to e0f4169 Compare November 2, 2025 09:17
@julien-deramond julien-deramond changed the title Build(deps-dev): Bump sass from 1.90.0 to 1.92.1 Build(deps-dev): Bump sass from 1.90.0 to 1.93.3 Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants