Ziggurat: Fix an underflow-bug and add a regression test #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasowski
changed the title
|
Apparently the regression test is flaky (I could also just remove it). It seems to works fine with the current test suite, but since the Ziggurat implementation is stateful, it may require a higher constant than 975, if another tests presses it. As far as I can see, the regression test will only pass, if some other test fails for this reason, so it does not seem to be a big problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1315. Details of debugging over there.
I added a regression test that fails without the fix to the
nfixfunction. It would be fantastic if this was merged soon, as this would simplify my build management downstream.