Ruff checks for RET. #763
Open
Ruff checks for RET. #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Butcher
force-pushed
the
feature/ruff-ret
branch
from
e99bfc9 to
b381c95
Compare
Signed-off-by: Eric Butcher <[email protected]>
Eric-Butcher
force-pushed
the
feature/ruff-ret
branch
from
b381c95 to
cd7e9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was a bit of a dousy.
Many of these fixes were safe fixes done by ruff automatically.
There was a bunch of bad logic in the Project views. I covered all of the uncovered edge cases with what I thought was the most reasonable. Mostly this meant returning a form with the errors in it or just returning a 404 error if a resource was not found.
This really highlights the the Project views need to be refactored.