Ctp 5133 unfinalise

[watson8]

• Gives managers the ability to manually unfinalise a submission after the deadline where late submissions are allowed, to permit the student to go back in to a previous submission and re-upload a new file / re-finalise it
• to do this, renames the existing mdl_coursework_submissions.finalised field to finalisedstatus, and introduces a new possible value for that field (was 0 = not finalised, 1 = finalised, now can be 2 = manually unfinalised
• where value is manually unfinalised, the submission will not be automatically finalised by cron or on page view - must be finalised by manual user action (student or manager)
• introduces constants to clarify what is happening e.g. const FINALISED_STATUS_MANUALLY_UNFINALISED = 2;
• includes behat tests which are passing

[andrewhancox]

Solid. A couple of minor changes.

[andrewhancox]

Reviewing now.

Note for anyone else looking who is questioning the amount of change required - I suggested to David that it would be best to rename the db field from finalised field to finalisedstatus rather than simply changing what is held in it so that any areas that get missed will throw an exception rather than just getting missed.

I've assumed all PHPUnit + Behat tests are passing.

[andrewhancox]

One comment but it's on a pre-existing bit of awfulness so no need to pick up now if you're keen to move on with your life.