feat: update of deps incl. bug fixes (Node >= 20) #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicoschoenteich - maybe we can talk about this PR? |
nicoschoenteich
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 18 is OOM and not supported anymore. Several dependencies require Node >= 20 in the meantime. We should also keep track here and not support legacy Node versions.
In this change I also upgraded several central dependencies and tools to their latest version. Bigger change was related to ESLint, Prettier and Husky. For Yeoman I kept them stable.
Nevertheless, there is an issue with Easy UI5 in BAS. Since we migrated to ESM modules for our generators, in Yeoman UI in BAS it doesn't work anymore. I tried several approaches the recent days but I think we need to open a bug for Yeoman UI. It is not possible to create a compat layer for those scenarios - besides maybe package and bundle the Yeoman generator (using webpack, rollup and transform it back to CJS).
During this excercise I detected several small issues and bugs - using non-declared NPM packages, missing parameters, ... which I corrected with this change.
Issue with BAS/VSCode (Yeoman UI) is reported here: SAP/yeoman-ui#850