-
Notifications
You must be signed in to change notification settings - Fork 2.8k
V17/19897 fix sql syntax issues #19899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v17/dev
Are you sure you want to change the base?
V17/19897 fix sql syntax issues #19899
Conversation
Hi there @idseefeld, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes SQL syntax issues by replacing hardcoded SQL queries with proper syntax-aware query building across the Umbraco infrastructure. The changes ensure database compatibility and proper column/table name quoting.
- Replace hardcoded SQL with syntax-aware query builders
- Update SQL queries to use proper quoting for table and column names
- Fix SQL injection vulnerabilities and ensure cross-database compatibility
Reviewed Changes
Copilot reviewed 66 out of 66 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
src/Umbraco.Web.UI/appsettings.Development.template.json | Fix port configuration format |
src/Umbraco.PublishedCache.HybridCache/Persistence/DatabaseCacheRepository.cs | Replace raw SQL with syntax-aware queries and add error handling |
src/Umbraco.Infrastructure/Persistence/UmbracoDatabaseExtensions.cs | Update column name retrieval method |
src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs | Add error handling for ExecuteScalar method |
src/Umbraco.Infrastructure/Persistence/SqlSyntax/*.cs | Add new methods for SQL syntax handling |
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/*.cs | Convert hardcoded SQL to syntax-aware queries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Prerequisites
I have chosen v17/dev branch because it was not clear when I could finish this PR and this gives you hopefully enough time for review and discussion.
I am available for discussions and changes this month.
This PR fixes #19897