Tiptap RTE: Toolbar configuration sorter #19901
Merged
+225
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6/fix-bug/tiptap-toolbar-sorter
|
Hi @NguyenThuyLan Looks good, I skimmed the code it, very good with the refactoring into a new group component 👏 Still need a proper review, @leekelleher will have a look at that :-) |
leekelleher
changed the title
- Renamed "toolbar-item-click" event to "remove", to show intent - Reordered the method names alphabetically - Renamed `value` to `items`, to show intent - Removed `toolbarValue`, as not required - Added `data-mark` for menu/styleMenu buttons
leekelleher
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
Super, thanks @NguyenThuyLan! 🚀
I've tested it out and it works great.
I have made some tweaks to the code, renamed a few things for consistency and intent.
Great work! 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Description
This PR fixes the issue #19571
Recording.2025-08-13.154711.mp4
I used the Umbraco Sorter controller for drag and drop Tiptap toolbar buttons.