V16: Unwarranted redirect after auth

[iOvergaard]

Description

Fixes #17642
Fixes #18334
Fixes #19750

This pull request refines the OAuth authorization flow in the backoffice app, improving both the handling and redirection logic after authentication. The main focus is to ensure users are redirected to their intended location after completing OAuth, and to improve error handling and code clarity. Key changes include updating the authorization completion logic to return more informative results, centralizing redirect logic, and improving error feedback.

OAuth flow and redirect improvements

• Updated the OAuth completion route setup in UmbAppElement to use an async function, handle errors more gracefully, and redirect users to their previous path or root after authorization using the new redirectToStoredPath utility. [1] [2]
• Replaced the use of retrieveStoredPath with the new redirectToStoredPath function for more consistent and centralized redirect behavior. [1] [2]

Authorization request handler enhancements

• Changed the return type of completeAuthorizationRequestIfPossible in AuthorizationRequestHandler to return an AuthorizationRequestResponse | null instead of void, allowing for more informative handling of the authorization result.

Utility function addition

• Added the redirectToStoredPath function to centralize and standardize the logic for redirecting users after authentication, replacing previous ad-hoc implementations.

How to test

Unwarranted redirects

1. Log in and go to somewhere in the backoffice (does not matter where)
2. Open a new tab with middle-click (so that the window.opener is activated)
3. Check that the first tab does not redirect

Stuck on oauth_complete

1. Log in
2. Go back in the browser so you hit the login screen
3. Log in again
4. You should now see a redirect to /oauth_complete, then to the backoffice (it may happen twice because the first try invalidates the existing session, which is expected)
5. Verify that you at no point get stuck on /oauth_complete without any response or indication

[Copilot]

Pull Request Overview

This pull request refines the OAuth authorization flow in the backoffice app to fix unwarranted redirects and improve handling after authentication. The changes focus on better redirect logic, error handling, and preventing users from getting stuck on the oauth_complete page.

• Centralized redirect logic with a new redirectToStoredPath utility function
• Enhanced OAuth completion flow with better error handling and authorization checks
• Updated authorization request handler to return more informative results

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
stored-path.function.ts	Added redirectToStoredPath utility function to centralize redirect logic
auth-flow.ts	Fixed authorization check to use getValue() method
authorization_request_handler.ts	Changed return type to provide authorization result information
app.element.ts	Improved OAuth completion setup with async handling and better redirect logic

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[ctolkien]

This is a major annoyance for our client, would be amazing to get it in. Thanks for your work on this @iOvergaard