Skip to content

Conversation

@madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Oct 11, 2024

Description

This PR is a small step towards reusable code across collection table views. We currently have duplicated code across our table column layout elements. This PR adds a "boolean" element and an "entity actions" element we now reuse across the tables. It will ensure the same UX across those columns.

The PR also implements entity actions for all collection table views.

I am unsure whether the word "layout" is used correctly in this instance. I am open to suggestions for a new name :)

Example:
Screenshot 2024-10-11 at 20 58 58

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen marked this pull request as ready for review October 11, 2024 19:04
@bjarnef
Copy link
Contributor

bjarnef commented Oct 15, 2024

@madsrasmussen perhaps "column template" or "column view" as we have "collection view".

Or if specific to layout of cell, perhaps "table cell view"?

@madsrasmussen madsrasmussen changed the title Feature: reusable table column layout components Feature: reusable table column view components Oct 21, 2024
@madsrasmussen
Copy link
Contributor Author

hi @bjarnef

I think "view" is better than "layout" so I have renamed it to that. I like that they are named "column" instead of "cell" because the view applies to all cells in a column. 🤔

Thanks 🙌

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, looking great! 🚀

@leekelleher leekelleher merged commit 3eef6b0 into main Nov 6, 2024
8 checks passed
@leekelleher leekelleher deleted the v15/feature/reusable-table-column-layouts branch November 6, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants