Feature: Markdown Editor toolbar styling #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to align with the Tiptap RTE toolbar style.
iOvergaard
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from #2495, updated the Markdown Editor toolbar to visually align with the Tiptap RTE toolbar, including using the same icons for heading, bold, italic, et al.
Before
After
This does introduce a change (feature), as the button icon for any
monacoMarkdownEditorActionextensions was hardcoded to "icon-link" (for the URL Picker feature), soMetaMonacoMarkdownEditorActionhas been updated to have an optionallabelandicon.Types of changes
How to test?
This is mostly a cosmetic change, but with the addition of the label/icon properties to the extension manifest, testing should be to make sure that the toolbar buttons all still function as expected.