-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fixed the error that the variable css_selector was originally assigned to list #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update documentation examples for the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
docs/md_v2/assets/llm.txt/txt/llms-full.txt (1)
1050-1054
: Earlier snippet still advertises list support – update for consistencyLine 1052’s comment
# Can be list of selectors
contradicts the one-string requirement introduced by this PR. Keeping both messages will confuse readers. Please adjust the comment (and, if needed, the surrounding prose) to reflect the new “single comma-separated string” guideline.
🧹 Nitpick comments (3)
docs/md_v2/assets/llm.txt/txt/llms-full-v0.1.1.txt (1)
1069-1076
: Update earlier comment to avoid mixed guidanceThis example now shows a single comma-separated string, which is great.
However, a few lines above (around 1052) the comment still says “Can be list of selectors”.
Please adjust that note (or remove it) so the documentation consistently reflects the new, string-only contract.docs/md_v2/assets/llm.txt/txt/config_objects.txt (2)
445-452
: Update earlier examples to avoid mixed guidance oncss_selector
.Great catch switching the example here to a comma-separated string.
However, a few lines above (line 428) we still comment “# Can be list of selectors
”, which now contradicts the stricter string-only guidance introduced by this PR. Tweaking that comment will prevent future confusion.@@ - css_selector="main.article, .content-area", # Can be list of selectors + css_selector="main.article, .content-area", # Comma-separated string of selectors
1169-1172
: Duplicate “Learn more” footer – consider removing one.Lines 1169 and 1171 show two nearly identical “📖 Learn more” blocks. Keeping a single consolidated list will read cleaner and avoid readers wondering whether they’ve missed a difference.
-**📖 Learn more:** [Hooks & Authentication](https://docs.crawl4ai.com/advanced/hooks-auth/), [Session Management](https://docs.crawl4ai.com/advanced/session-management/), [Network Monitoring](https://docs.crawl4ai.com/advanced/network-console-capture/), [Page Interaction](https://docs.crawl4ai.com/core/page-interaction/), [File Downloads](https://docs.crawl4ai.com/advanced/file-downloading/)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/md_v2/assets/llm.txt/txt/config_objects.txt
(2 hunks)docs/md_v2/assets/llm.txt/txt/llms-full-v0.1.1.txt
(1 hunks)docs/md_v2/assets/llm.txt/txt/llms-full.txt
(1 hunks)
🔇 Additional comments (1)
docs/md_v2/assets/llm.txt/txt/llms-full.txt (1)
1068-1076
: Good fix, but consider mirroring the change in all code blocksThe switch to a comma-separated string for
css_selector
is correct here. Make sure every other example in this document (and inconfig_objects.txt
,llms-full-v0.1.1.txt
, etc.) follows the same pattern to avoid mixed messaging.
Summary
In CrawlerRunConfig, the css_selector is string, and will be split. but these files in doc css_selector is assigned an initial value of list type.
List of files changed and why
eg: quickstart.py - To update the example as per new changes
docs\md_v2\assets\llm.txt\txt\config_objects.txt - To change css_selector's value
docs\md_v2\assets\llm.txt\txt\llms-full.txt - To change css_selector's value
docs\md_v2\assets\llm.txt\txt\llms-full-v0.1.1.txt - To change css_selector's value
Summary by CodeRabbit
css_selector
parameter in configuration documentation to use a single comma-separated string instead of a list of selectors.