Skip to content

Conversation

ristoalas
Copy link

This adds support for sending API keys to the subscription proxy of aggregators. It also adds a couple of exceptions for error cases.

@ristoalas ristoalas requested a review from martti007 September 26, 2025 07:20
@martti007 martti007 requested a review from Copilot September 26, 2025 08:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for sending API keys to the subscription proxy of aggregators, enabling authentication for protected endpoints. It also introduces new exception types for handling authorization and rate limiting errors.

Key changes:

  • Adds API key support to AggregatorClient with optional authentication
  • Introduces UnauthorizedException and RateLimitExceededException for error handling
  • Updates JsonRpcHttpTransport to handle API key headers and HTTP error responses

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TestApiKeyIntegration.java Comprehensive test suite for API key authentication scenarios
MockAggregatorServer.java Test mock server with API key validation and rate limiting simulation
UnauthorizedException.java New exception for HTTP 401 unauthorized errors
RateLimitExceededException.java New exception for HTTP 429 rate limit errors with retry information
JsonRpcHttpTransport.java Enhanced transport layer with API key support and error handling
AggregatorClient.java Updated client with optional API key constructor and authentication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants