Re-enable “Nix development cache” workflow #5625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of doing it for every PR push, only run it for trunk & releases. The former keeps an up-to-date dev environment in the cache (and lets us know if something needs to be fixed before the next release) while the latter gives us something to pin for downstream consumers (and quick access to releases when bisecting for bugs, etc.).
Since it’s not the primary build tool, this gets it out of the way and allows for more detailed Nix documentation without overwhelming the core docs.
And reference them in the development docs, so contributors can more easily discover what versions we use.
|
Oh yeah, and I manually ran the workflow on this PR, so I could check that the re-addition of aarch64-darwin succeeded: https://github.com/sellout/unison/actions/runs/13821109924/job/38666414462 |
aryairani
reviewed
Mar 18, 2025
| vscodeSettings."haskell.toolchain" | ||
| ## There are some things we want to pin that the VS Code Haskell extension doesn’t let us control. | ||
| // { | ||
| hpack = "0.35.2"; |
There was a problem hiding this comment.
I have seen some hpack 0.37 slipping in, so we may want to bump this too at some point.
There was a problem hiding this comment.
Yeah, good call. In #5486, I mention that 0.36 is the minimum supported by our pinned stack version, so it’s even inconsistent within the current Nix environment. I should rebase that, now that this is merged, and see if the cache issue is gone.
aryairani
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This re-enables some automatic running of Nix build & cache population.
Unlike before it was disabled, this doesn’t run on PRs, only on release branches and trunk. The former lets us pin releases for quick comparisons and downstream usage, while the latter keeps the dev tools up-to-date and gives us an early warning if the Nix build breaks (without getting in the way of PRs).
It’s still possible to run manually, which is helpful to test PRs like this, which affect the Nix tooling, as well as ensuring that Nix tooling changes are propagated to the cache before they’re merged into trunk.
Implementation notes
This also has a couple other non-cache-breaking changes, like separating out the Nix documentation from other dev docs as well as separating out the tool versions and referencing them from the docs as well.
Test coverage
This re-enables the testing of the Nix build in CI, but in a less obtrusive way than before.
Loose ends
There are other Nix changes that have been waiting, like #5486, but this is a low-effort improvement that is worth getting in before those anyway.
Also, it might be useful to have this workflow automatically trigger on changes to paths matching “nix” and a couple others that are referenced by the Nix build, but I think this is good for now.